On wtorek, 5 marca 2013 o 18:34:43 Mandeep Singh Baines wrote: > Fixes the following lockdep error: > > [ BUG: ktpacpi_nvramd/446 still has locks held! ] > > hotkey_kthread() calls set_freezable() after acquiring the > hotkey_kthread_mutex(). set_freezable() calls try_to_freeze(). > This could block suspend if we were to freeze at this point > and another task were to block on the mutex, potentially via > writing to one of the sysfs attrs. This race is unlikely but > can be easily fixed by moving the set_freezable() call. > > Reported-by: Maciej Rutecki <maciej.rute...@gmail.com> > Signed-off-by: Mandeep Singh Baines <m...@chromium.org> > CC: Aaron Lu <aaron...@intel.com> > CC: Henrique de Moraes Holschuh <h...@hmh.eng.br> > CC: Tejun Heo <t...@kernel.org> > CC: Oleg Nesterov <o...@redhat.com> > CC: Andrew Morton <a...@linux-foundation.org> Tested-by: Maciej Rutecki <maciej.rute...@gmail.com>
Patch fixes the problem. Thanks! Regards -- Maciej Rutecki http://www.mrutecki.pl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
