On Tue, Mar 05, 2013 at 11:03:52AM -0800, Bryan Wu wrote: > On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown
> > if (ret != 0) {
> > dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n",
> > ret);
> > - regulator_enable(led->dcdc);
> > + ret = regulator_enable(led->dcdc);
> > + if (ret != 0) {
> looks like we don't need this bracket here.
>
> > + dev_err(led->cdev.dev, "Failed to reenable DCDC:
> > %d\n",
> > + ret);
> > + }
> ditto.
It's not required but since it's inside a small but multi-line block
there's the whole thing about including braces at all levels for
clarity.
signature.asc
Description: Digital signature
