On Thu, 7 Mar 2013, Daniel Baluta wrote: > > Removed the following sparse warnings: > > * mm/hugetlb.c:1764:6: warning: symbol > > 'hugetlb_unregister_node' was not declared. > > Should it be static? > > * mm/hugetlb.c:1808:6: warning: symbol > > 'hugetlb_register_node' was not declared. > > Should it be static? > > > > Signed-off-by: Claudiu Ghioc <claudiu.gh...@gmail.com> > > --- > > mm/hugetlb.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 0a0be33..c65a8a5 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -1761,7 +1761,7 @@ static struct hstate *kobj_to_node_hstate(struct > > kobject *kobj, int *nidp) > > * Unregister hstate attributes from a single node device. > > * No-op if no hstate attributes attached. > > */ > > -void hugetlb_unregister_node(struct node *node) > > +static void hugetlb_unregister_node(struct node *node) > > { > > struct hstate *h; > > struct node_hstate *nhs = &node_hstates[node->dev.id]; > > @@ -1805,7 +1805,7 @@ static void hugetlb_unregister_all_nodes(void) > > * Register hstate attributes for a single node device. > > * No-op if attributes already registered. > > */ > > -void hugetlb_register_node(struct node *node) > > +static void hugetlb_register_node(struct node *node) > > { > > struct hstate *h; > > struct node_hstate *nhs = &node_hstates[node->dev.id]; > > Can you pick this up via trivial tree?
Seems like sparse is correct here, as register_hugetlbfs_with_node is passing pointers to those functions. Will take it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/