Hi Prabhakar, On 3/7/2013 12:44 PM, Prabhakar lad wrote: > From: Lad, Prabhakar <[email protected]> > > export the symbols which are used by two modules vpif_capture and > vpif_display. > > This patch fixes following error: > ERROR: "ch_params" [drivers/media/platform/davinci/vpif_display.ko] undefined! > ERROR: "vpif_ch_params_count" > [drivers/media/platform/davinci/vpif_display.ko] undefined! > ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_display.ko] undefined! > ERROR: "ch_params" [drivers/media/platform/davinci/vpif_capture.ko] undefined! > ERROR: "vpif_ch_params_count" > [drivers/media/platform/davinci/vpif_capture.ko] undefined! > ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_capture.ko] undefined! > make[1]: *** [__modpost] Error 1 > > Reported-by: Sekhar Nori <[email protected]> > Signed-off-by: Lad, Prabhakar <[email protected]> > --- > drivers/media/platform/davinci/vpif.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/platform/davinci/vpif.c > b/drivers/media/platform/davinci/vpif.c > index 28638a8..8fbb4a2 100644 > --- a/drivers/media/platform/davinci/vpif.c > +++ b/drivers/media/platform/davinci/vpif.c > @@ -44,6 +44,8 @@ static struct resource *res; > spinlock_t vpif_lock; > > void __iomem *vpif_base; > +EXPORT_SYMBOL(vpif_base);
Should be EXPORT_SYMBOL_GPL() as nothing except GPL code would be needing this internal symbol. Also exporting this shows that the driver is written for only one instance. It seems to me that the driver modules can use much better abstractions so all these exports wont be needed but having broken module build is bad as well. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
