On 7 March 2013 12:13, Amit Daniel Kachhap <amit.dan...@samsung.com> wrote:
> diff --git a/drivers/cpufreq/exynos5440-cpufreq.c
> b/drivers/cpufreq/exynos5440-cpufreq.c
> +struct exynos_dvfs_data {
> + void __iomem *base;
> + struct resource *mem;
> + int irq;
> + struct clk *cpu_clk;
> + unsigned int cur_frequency;
> + unsigned int latency;
> + struct cpufreq_frequency_table *freq_table;
> + unsigned int freq_count;
> + struct device *dev;
> + bool dvfs_enable;
s/enable/enabled?
> +static int exynos_cpufreq_probe(struct platform_device *pdev)
> + dvfs_info->cpu_clk = devm_clk_get(dvfs_info->dev, "armclk");
> + if (IS_ERR_OR_NULL(dvfs_info->cpu_clk)) {
s/IS_ERR_OR_NULL/IS_ERR
> + if (devm_request_irq(dvfs_info->dev, dvfs_info->irq,
> exynos_cpufreq_irq,
> + IRQF_TRIGGER_NONE, CPUFREQ_NAME, dvfs_info)) {
> + pr_err("Failed to register IRQ\n");
> + ret = -ENODEV;
use the value returned from this function rather than creating your
own.. true for all
other calls too, unless they return NULL on error.
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
