On Thu, Apr 19, 2001 at 11:56:01AM -0400, Jeff Garzik wrote:
> Marcus Meissner wrote:
> >
> > Hi,
> >
> > This updates the nm256_audio driver to the 2.4 PCI API.
> >
> > Patch is against 2.4.3-ac9, verified on Sony VAIO Laptop.
>
> "verified" is the really important part with this driver, since its
> really finicky. I have a patch I would love to bounce to you in
> private, that I have been searching for a tester for -months- because I
> had no test hardware of my own.
Feel free to send (I have a NM256AV card in that VAIO).
> Your patch looks ok to me and I would say apply it. But I also think it
> is incomplete.
>
> * there is no need for a linked list of cards, since
> pci_{get,set}_drvdata is used. This eliminates the list walk in
> nm256_remove
The problem is with device opens, which just pass numbers, most other
sound drivers still use linked lists.
Hmm, but via8xxxx_audio.c doesn't, I will take this as example.
> * the new PCI API has suspend/resume hooks, and those should be used in
> preference to register_pm_...
Ok, will have another look at the other issues.
And I hope my colleague brings his VAIO to work tomorrow ;)
Ciao, Marcus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
