Thanks for catching that typo Acked-by: Graeme Gregory <[email protected]>
On 12/03/13 15:40, Axel Lin wrote: > It does not make sense to assign return value of of_property_read_u32() to > pdata->reg_init[idx]->warm_reset. Use of_property_read_bool() to read > "ti,warm-reset" DT property instead which will return correct setting > for pdata->reg_init[idx]->warm_reset. > > Signed-off-by: Axel Lin <[email protected]> > --- > drivers/regulator/palmas-regulator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/palmas-regulator.c > b/drivers/regulator/palmas-regulator.c > index b2b1baa..a9b558e 100644 > --- a/drivers/regulator/palmas-regulator.c > +++ b/drivers/regulator/palmas-regulator.c > @@ -554,8 +554,8 @@ static void palmas_dt_to_pdata(struct device *dev, > sizeof(struct palmas_reg_init), GFP_KERNEL); > > pdata->reg_init[idx]->warm_reset = > - of_property_read_u32(palmas_matches[idx].of_node, > - "ti,warm-reset", &prop); > + of_property_read_bool(palmas_matches[idx].of_node, > + "ti,warm-reset"); > > pdata->reg_init[idx]->roof_floor = > of_property_read_bool(palmas_matches[idx].of_node, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
