On Mon, 2013-03-11 at 16:17 -0500, Seth Forshee wrote: > Here's a patch that does the command line option. I'm happy with either > one.
I like the idea, but isn't the logic backwards? I would have expected s/EFI_VARS_PSTORE_DEFAULT_DISABLE/EFI_VARS_PSTORE/g and then 'default y' in the Kconfig file to maintain backward compatibility? Is there a reason that wouldn't work? I know that Linus has previously denounced setting new Kconfig symbols to 'y' by default, but I think there's a case here for doing exactly that since the previous behaviour was always enabled. The networking folks did something similar recently, where they introduced new Kconfig symbols for existing functionality that was previously on by default. [...] > +#ifdef CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE > +static bool efivars_pstore_disable = true; > +#else > +static bool efivars_pstore_disable = false; > +#endif > +module_param_named(pstore_disable, efivars_pstore_disable, bool, 0644); > + static bool efivars_pstore_enable = IS_ENABLED(CONFIG_EFI_VARS_PSTORE) ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
