On Tue, Mar 12, 2013 at 9:10 PM, Joe Perches <j...@perches.com> wrote: > On Tue, 2013-03-12 at 20:30 +0200, Silviu-Mihai Popescu wrote: >> Use resource_size() instead of explicit calculation. This was found via >> make coccicheck. > [] >> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c >> b/drivers/net/ethernet/nxp/lpc_eth.c > [] >> @@ -1421,7 +1421,7 @@ static int lpc_eth_drv_probe(struct platform_device >> *pdev) >> netdev_dbg(ndev, "IO address start :0x%08x\n", >> res->start); >> netdev_dbg(ndev, "IO address size :%d\n", >> - res->end - res->start + 1); >> + resource_size(res)); > > This might be better as > > netdev_dbg(ndev, "IO resource :%pR\n", res); > >
Thanks for the review. I've refreshed the patch and sent it again. -- Silviu Popescu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
