On Tue, Mar 5, 2013 at 1:32 AM, Magnus Damm <magnus.d...@gmail.com> wrote:
> +static int gpio_rcar_irq_set_type(struct irq_data *d, unsigned int type)
> +{
> + struct gpio_rcar_priv *p = irq_data_get_irq_chip_data(d);
> + unsigned int hwirq = irqd_to_hwirq(d);
> +
> + pr_debug("gpio: sense irq = %d, type = %d\n", hwirq, type);
> +
> + switch (type & IRQ_TYPE_SENSE_MASK) {
> + case IRQ_TYPE_LEVEL_HIGH:
> + gpio_rcar_config_interrupt_input_mode(p, hwirq, true, true);
> + break;
> + case IRQ_TYPE_LEVEL_LOW:
> + gpio_rcar_config_interrupt_input_mode(p, hwirq, false, true);
> + break;
> + case IRQ_TYPE_EDGE_RISING:
> + gpio_rcar_config_interrupt_input_mode(p, hwirq, true, false);
> + break;
> + case IRQ_TYPE_EDGE_FALLING:
> + gpio_rcar_config_interrupt_input_mode(p, hwirq, false, false);
> + break;
It is quite common to request IRQ on *both* rising and falling edges,
what happens then?
See <linux/irqs.h>
IRQ_TYPE_EDGE_RISING = 0x00000001,
IRQ_TYPE_EDGE_FALLING = 0x00000002,
IRQ_TYPE_EDGE_BOTH = (IRQ_TYPE_EDGE_FALLING |
IRQ_TYPE_EDGE_RISING),
I guess then you get just rising edge...
> + default:
> + return -EINVAL;
> + }
> + return 0;
> +}
(...)
The rest I think is already covered by Laurent's comments.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
