On Wed, 6 Mar 2013 20:55:53 -0500 Andrew Shewmaker <ags...@gmail.com> wrote:
> Should I enforce a minimum for the admin reserve? 8MB/128MB for the > overcommit guess/never modes? I was hesitant to do that since my > numbers are based a full-featured distro's versions of login, bash, > etc. A more svelte distro based on BusyBox might want different > minimums. I'd say not. It requires CAP_SYS_ADMIN and we generally prefer to give root the flexibility to shoot his foot off if he feels so inclined. > I have a question concerning the variable names. Might a person > looking at the source be confused why admin_reserve_kbytes and > user_reserve_kbytes are not included in totalreserve_pages? Should > I use a word other than "reserve" in the names, like "safetynet"? > I can't think of anything better. Maybe it isn't a concern, but > I didn't want to cause confusion. mm.. I wouldn't worry about it personally. As long as we have nice comments at the various definition sites, readers should be able to work out the difference quite easily. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
