On Thu, 14 Mar 2013 06:33:04 -0700, Guenter Roeck wrote: > On Thu, Mar 14, 2013 at 11:23:54AM +0100, Jean Delvare wrote: > > Hi Axel, > > > > On Thu, 14 Mar 2013 16:27:18 +0800, Axel Lin wrote: > > > Signed-off-by: Axel Lin <[email protected]> > > > --- > > > drivers/hwmon/lineage-pem.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c > > > index 41df29f..ebbb9f4 100644 > > > --- a/drivers/hwmon/lineage-pem.c > > > +++ b/drivers/hwmon/lineage-pem.c > > > @@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = { > > > &sensor_dev_attr_in2_input.dev_attr.attr, > > > &sensor_dev_attr_curr1_input.dev_attr.attr, > > > &sensor_dev_attr_power1_input.dev_attr.attr, > > > + NULL > > > }; > > > > > > static const struct attribute_group pem_input_group = { > > > @@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = { > > > &sensor_dev_attr_fan1_input.dev_attr.attr, > > > &sensor_dev_attr_fan2_input.dev_attr.attr, > > > &sensor_dev_attr_fan3_input.dev_attr.attr, > > > + NULL > > > }; > > > > > > static const struct attribute_group pem_fan_group = { > > > > Good catch. > > > > Acked-by: Jean Delvare <[email protected]> > > > > I'll let Guenter pick the fix as this is his driver. This should go to > > stable too. > > Will do. Just wonder why this never blew up in my face, as we use that driver > in my previous company :).
I've seen it before. I suspect we are saved by the fact that the first member of struct attribute_group is const char *name, which is almost never set in the hwmon drivers. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
