On Fri, 2013-03-15 at 22:51 +0000, Abodunrin, Akeem G wrote: > -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Joe Perches [] > Reduce the number of calls required to alloc a zeroed block of memory. [] > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c > b/drivers/net/ethernet/intel/igbvf/netdev.c [] > @@ -488,7 +487,6 @@ int igbvf_setup_rx_resources(struct igbvf_adapter > *adapter, > > rx_ring->desc = dma_alloc_coherent(&pdev->dev, rx_ring->size, > &rx_ring->dma, GFP_KERNEL); > - > if (!rx_ring->desc) > goto err; > > Hi Joe,
Hello Akeem. > Your changes did not seem to make it to igbvf/netdev.c - I think > instead of removing an extra line added for code clarity, you > want to add: > "tx_ring->desc = dma_alloc_coherent(&pdev->dev, tx_ring->size, > &tx_ring->dma, GFP_KERNEL| > __GFP_ZERO);" Not really, there's no memset here so this bit is just a whitespace neatening. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
