Commit-ID: 65c10553552b487a71bf5e4676743435046fae6f Gitweb: http://git.kernel.org/tip/65c10553552b487a71bf5e4676743435046fae6f Author: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> AuthorDate: Thu, 14 Mar 2013 20:52:30 +0900 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Mon, 18 Mar 2013 10:21:23 +0100
kprobes: Make hash_64() as always inlined Because hash_64() is called from the get_kprobe() inside int3 handler, kernel causes int3 recursion and crashes if kprobes user puts a probe on it. Usually hash_64() is inlined into caller function, but in some cases, it has instances by gcc's interprocedural constant propagation. This patch uses __always_inline instead of inline to prevent gcc from doing such things. Reported-by: Timo Juhani Lindfors <timo.lindf...@iki.fi> Signed-off-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Acked-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Pavel Emelyanov <xe...@parallels.com> Cc: Jiri Kosina <jkos...@suse.cz> Cc: Nadia Yvette Chambers <n...@holomorphy.com> Cc: yrl.pp-manager...@hitachi.com Cc: David S. Miller <da...@davemloft.net> Cc: Linus Torvalds <torva...@linux-foundation.org> Link: http://lkml.kernel.org/r/20130314115230.19690.39387.stgit@mhiramat-M0-7522 Signed-off-by: Ingo Molnar <mi...@kernel.org> --- include/linux/hash.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/hash.h b/include/linux/hash.h index 61c97ae..f09a0ae 100644 --- a/include/linux/hash.h +++ b/include/linux/hash.h @@ -15,6 +15,7 @@ */ #include <asm/types.h> +#include <linux/compiler.h> /* 2^31 + 2^29 - 2^25 + 2^22 - 2^19 - 2^16 + 1 */ #define GOLDEN_RATIO_PRIME_32 0x9e370001UL @@ -31,7 +32,7 @@ #error Wordsize not 32 or 64 #endif -static inline u64 hash_64(u64 val, unsigned int bits) +static __always_inline u64 hash_64(u64 val, unsigned int bits) { u64 hash = val; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
