From: Nicolas Ferre <nicolas.fe...@atmel.com>

The status of transfer is stored in controller data structure
so that it can be used not only by atmel_spi_msg_done() function.
This will be useful for upcoming dmaengine enabled driver.

Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com>
Cc: spi-devel-gene...@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
[wenyou.y...@atmel.com: submit the patch]
Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>
---
 drivers/spi/spi-atmel.c |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index e3af244..4692f1f 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -209,6 +209,7 @@ struct atmel_spi {
        unsigned long           current_remaining_bytes;
        struct spi_transfer     *next_transfer;
        unsigned long           next_remaining_bytes;
+       int                     done_status;
 
        void                    *buffer;
        dma_addr_t              buffer_dma;
@@ -554,15 +555,15 @@ static void atmel_spi_dma_unmap_xfer(struct spi_master 
*master,
 
 static void
 atmel_spi_msg_done(struct spi_master *master, struct atmel_spi *as,
-               struct spi_message *msg, int status, int stay)
+               struct spi_message *msg, int stay)
 {
-       if (!stay || status < 0)
+       if (!stay || as->done_status < 0)
                cs_deactivate(as, msg->spi);
        else
                as->stay = msg->spi;
 
        list_del(&msg->queue);
-       msg->status = status;
+       msg->status = as->done_status;
 
        dev_dbg(master->dev.parent,
                "xfer complete: %u bytes transferred\n",
@@ -574,6 +575,7 @@ atmel_spi_msg_done(struct spi_master *master, struct 
atmel_spi *as,
 
        as->current_transfer = NULL;
        as->next_transfer = NULL;
+       as->done_status = 0;
 
        /* continue if needed */
        if (list_empty(&as->queue) || as->stopping)
@@ -651,7 +653,8 @@ atmel_spi_interrupt(int irq, void *dev_id)
                /* Clear any overrun happening while cleaning up */
                spi_readl(as, SR);
 
-               atmel_spi_msg_done(master, as, msg, -EIO, 0);
+               as->done_status = -EIO;
+               atmel_spi_msg_done(master, as, msg, 0);
        } else if (pending & (SPI_BIT(RXBUFF) | SPI_BIT(ENDRX))) {
                ret = IRQ_HANDLED;
 
@@ -669,7 +672,7 @@ atmel_spi_interrupt(int irq, void *dev_id)
 
                        if (atmel_spi_xfer_is_last(msg, xfer)) {
                                /* report completed message */
-                               atmel_spi_msg_done(master, as, msg, 0,
+                               atmel_spi_msg_done(master, as, msg,
                                                xfer->cs_change);
                        } else {
                                if (xfer->cs_change) {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to