On Thu, 21 Mar 2013, Ingo Molnar wrote: > > Index: linux/mm/page_alloc.c > > =================================================================== > > --- linux.orig/mm/page_alloc.c 2013-03-18 10:52:11.510988843 -0500 > > +++ linux/mm/page_alloc.c 2013-03-18 10:52:14.214931348 -0500 > > @@ -4161,10 +4161,19 @@ int __meminit __early_pfn_to_nid(unsigne > > { > > unsigned long start_pfn, end_pfn; > > int i, nid; > > + static unsigned long last_start_pfn, last_end_pfn; > > + static int last_nid; > > Please move these globals out of function local scope, to make it more > apparent that they are not on-stack. I only noticed it in the second pass. >
The way they're currently defined places these in meminit.data as appropriate; if they are moved out, please make sure to annotate their definitions with __meminitdata. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/