From: Andi Kleen <[email protected]> Writing _xbegin which is like setjmp in a if is very natural. Stop checkpatch's whining about this.
Cc: [email protected] Signed-off-by: Andi Kleen <[email protected]> --- scripts/checkpatch.pl | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b28cc38..659e683 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2831,7 +2831,10 @@ sub process { $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { my ($s, $c) = ($stat, $cond); - if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) { + # if ((status = _xbegin()) == _XBEGIN_STARTED) is natural, + # so don't warn about this case. + if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s && + $c !~ /_xbegin/) { ERROR("ASSIGN_IN_IF", "do not use assignment in if condition\n" . $herecurr); } -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
