On Mon, 25 Mar 2013, Axel Lin wrote: > > Both ab8500_regulator_mode_ops and ab8500_regulator_ops do not have volt_table > setting, thus we can not use regulator_list_voltage_table for them. > However, they have min_uV setting with n_voltages = 1, so use > regulator_list_voltage_linear instead. > > Also remove setting set_voltage_time_sel for ab8500_regulator_mode_ops. > It is used only for fixed voltage, so it does not need to implement > set_voltage_time_sel. > > Signed-off-by: Axel Lin <[email protected]>
Looks good to me. Acked-by: Lee Jones <[email protected]> > --- > drivers/regulator/ab8500.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c > index a2d19c6..12e2740 100644 > --- a/drivers/regulator/ab8500.c > +++ b/drivers/regulator/ab8500.c > @@ -363,8 +363,7 @@ static struct regulator_ops ab8500_regulator_mode_ops = { > .set_mode = ab8500_regulator_set_mode, > .get_mode = ab8500_regulator_get_mode, > .get_voltage_sel = ab8500_regulator_get_voltage_sel, > - .list_voltage = regulator_list_voltage_table, > - .set_voltage_time_sel = ab8500_regulator_set_voltage_time_sel, > + .list_voltage = regulator_list_voltage_linear, > }; > > static struct regulator_ops ab8500_regulator_ops = { > @@ -372,7 +371,7 @@ static struct regulator_ops ab8500_regulator_ops = { > .disable = ab8500_regulator_disable, > .is_enabled = ab8500_regulator_is_enabled, > .get_voltage_sel = ab8500_regulator_get_voltage_sel, > - .list_voltage = regulator_list_voltage_table, > + .list_voltage = regulator_list_voltage_linear, > }; > > static struct ab8500_regulator_info -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
