[Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On
28/03/2013 (Thu 19:00) Paul E. McKenney wrote:
> On Fri, Mar 29, 2013 at 01:39:04AM +0100, Frederic Weisbecker wrote:
> > 2013/3/29 Paul Gortmaker <paul.gortma...@windriver.com>:
> > > [Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On
> > > 28/03/2013 (Thu 08:40) Ingo Molnar wrote:
> > >
> > >>
> > >> * Frederic Weisbecker <fweis...@gmail.com> wrote:
> > >>
> > >> > + cpulist_scnprintf(nohz_ext_buf, sizeof(nohz_ext_buf),
> > >> > nohz_extended_mask);
> > >> > + pr_info("NO_HZ: Experimental full dynticks CPUs: %s.\n",
> > >> > nohz_ext_buf);
> > >>
> > >> I'd suggest removing the 'experimental' word. We are not sending anything
> > >> experimental to Linus: we'll send something that is tested and that we
> > >> expect to not break anything. (and which we'll fix if it does)
> > >
> > > In that case, should we vector a patch through PaulM to clobber these too?
> > >
> > > $ git grep xperiment |grep rcu
> > > kernel/rcutree_plugin.h: printk(KERN_INFO "\tExperimental boot-time
> > > adjustment of leaf fanout to %d.\n", rcu_fanout_leaf);
>
> This one has been this way for quite some time. I must confess that I am
> more inclined to remove this Kconfig option entirely than I am to remove
> the "Experimental". ;-)
>
> > > kernel/rcutree_plugin.h: pr_info("\tExperimental no-CBs CPUs: %s.\n",
> > > nocb_buf);
> > > kernel/rcutree_plugin.h: pr_info("\tExperimental polled no-CBs CPUs.\n");
> >
> > Hehe, that's indeed what I inspired from ;-)
>
> I guess we can rerun the earlier "how to mark Kconfig options as not
> yet being ready for 100 million unsuspecting victims^Wusers. ;-)
Perhaps consider "hiding" these kinds of choices behind CONFIG_EXPERT ?
P.
--
>
> Then again, I do have the warning at the bottom of the help info,
> so might be OK removing the "Experimental".
>
> Thanx, Paul
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
