On Thu, Mar 28, 2013 at 03:16:29PM +0100, Sebastien Royen wrote: > From: seb <sebastien.ro...@armadeus.com> > > Event value is wrong. Should be in range -2048 to 2047, but is in range 0 to > 4095. > Use s8 to int conversion and remove 0xfff mask. > > Signed-off-by: Sebastien Royen <sebastien.ro...@armadeus.com>
Applied, thank you Sebastien. > --- > drivers/input/misc/mma8450.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c > index 480557f..f330969 100644 > --- a/drivers/input/misc/mma8450.c > +++ b/drivers/input/misc/mma8450.c > @@ -123,9 +123,9 @@ static void mma8450_poll(struct input_polled_dev *dev) > if (ret < 0) > return; > > - x = ((buf[1] << 4) & 0xff0) | (buf[0] & 0xf); > - y = ((buf[3] << 4) & 0xff0) | (buf[2] & 0xf); > - z = ((buf[5] << 4) & 0xff0) | (buf[4] & 0xf); > + x = ((int)(s8)buf[1] << 4) | (buf[0] & 0xf); > + y = ((int)(s8)buf[3] << 4) | (buf[2] & 0xf); > + z = ((int)(s8)buf[5] << 4) | (buf[4] & 0xf); > > input_report_abs(dev->input, ABS_X, x); > input_report_abs(dev->input, ABS_Y, y); > -- > 1.7.9.5 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
