On Tue, Mar 19, 2013 at 03:42:15PM +0800, Wenyou Yang wrote:
> +{
> + unsigned int version;
> +
> + version = atmel_get_version(as);
> + dev_info(&as->pdev->dev, "version: 0x%x\n", version);
> +
> + as->caps.is_spi2 = (version > 0x121) ? true : false;
> + as->caps.has_wdrbt = (version >= 0x210) ? true : false;
> + as->caps.has_dma_support = (version >= 0x212) ? true : false;
> +}
> +There's absolutely no need for the ternery operators here - your comparisons are already boolean, the ternery operators just add noise. I've applied this with the above edited to remove the ? true : false, thanks.
signature.asc
Description: Digital signature
