[PATCH] regulator: ab8500-ext: Don't update info->is_enabled if write to register fails

[Axel Lin]

Signed-off-by: Axel Lin <axel....@ingics.com>
---
 drivers/regulator/ab8500-ext.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c
index 21b9bfb..7923e82 100644
--- a/drivers/regulator/ab8500-ext.c
+++ b/drivers/regulator/ab8500-ext.c
@@ -72,9 +72,11 @@ static int enable(struct ab8500_ext_regulator_info *info, u8 
*regval)
        ret = abx500_mask_and_set_register_interruptible(info->dev,
                info->update_bank, info->update_reg,
                info->update_mask, *regval);
-       if (ret < 0)
+       if (ret < 0) {
                dev_err(rdev_get_dev(info->rdev),
                        "couldn't set enable bits for regulator\n");
+               return ret;
+       }
 
        info->is_enabled = true;
 
@@ -117,9 +119,11 @@ static int disable(struct ab8500_ext_regulator_info *info, 
u8 *regval)
        ret = abx500_mask_and_set_register_interruptible(info->dev,
                info->update_bank, info->update_reg,
                info->update_mask, *regval);
-       if (ret < 0)
+       if (ret < 0) {
                dev_err(rdev_get_dev(info->rdev),
                        "couldn't set disable bits for regulator\n");
+               return ret;
+       }
 
        info->is_enabled = false;
 
-- 
1.7.10.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/