From: Rob Herring <robherri...@gmail.com> Date: Mon, 01 Apr 2013 14:14:10 -0500
> On 04/01/2013 02:01 PM, Guenter Roeck wrote: >> On Mon, Apr 01, 2013 at 01:44:24PM -0500, Rob Herring wrote: >>> On 04/01/2013 01:19 PM, Guenter Roeck wrote: >>>> of_get_mac_address() and of_get_phy_mode() are only provided if OF_NET >>>> is configured. While most callers check for the define, not all do, and >>>> those >>>> who do require #ifdef around the code. For those who don't, the missing >>>> check >>>> can result in errors such as >>> >>> How about removing the ifdef from those callers? >>> >> That would be the next step, after/if this one is accepted. >> If not, it doesn't make sense to waste my time. > > Assuming that is done: > > Acked-by: Rob Herring <rob.herr...@calxeda.com> > > Presumably with the follow-on patches, this can go in thru the net tree. Indeed, please resubmit this with the follow-on cleanups. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
