ACK.--b.

On Wed, Mar 27, 2013 at 09:18:06AM -0400, Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
> Cc: "J. Bruce Fields" <bfie...@fieldses.org>
> Cc: linux-...@vger.kernel.org
> ---
>  fs/nfsd/nfs4state.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 2e27430..2efb034 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -234,7 +234,6 @@ static struct nfs4_stid *nfs4_alloc_stid(struct 
> nfs4_client *cl, struct
>  kmem_cache *slab)
>  {
>       struct idr *stateids = &cl->cl_stateids;
> -     static int min_stateid = 0;
>       struct nfs4_stid *stid;
>       int new_id;
>  
> @@ -242,7 +241,7 @@ kmem_cache *slab)
>       if (!stid)
>               return NULL;
>  
> -     new_id = idr_alloc(stateids, stid, min_stateid, 0, GFP_KERNEL);
> +     new_id = idr_alloc_cyclic(stateids, stid, 0, 0, GFP_KERNEL);
>       if (new_id < 0)
>               goto out_free;
>       stid->sc_client = cl;
> @@ -261,10 +260,6 @@ kmem_cache *slab)
>        * amount of time until an id is reused, by ensuring they always
>        * "increase" (mod INT_MAX):
>        */
> -
> -     min_stateid = new_id+1;
> -     if (min_stateid == INT_MAX)
> -             min_stateid = 0;
>       return stid;
>  out_free:
>       kfree(stid);
> @@ -1287,7 +1282,7 @@ static struct nfs4_client *create_client(struct 
> xdr_netobj name,
>               spin_unlock(&nn->client_lock);
>               return NULL;
>       }
> -     idr_init(&clp->cl_stateids);
> +     idr_init_cyclic(&clp->cl_stateids, 0);
>       atomic_set(&clp->cl_refcount, 0);
>       clp->cl_cb_state = NFSD4_CB_UNKNOWN;
>       INIT_LIST_HEAD(&clp->cl_idhash);
> -- 
> 1.7.11.7
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to