On Friday 05 April 2013, Tomas Winkler wrote:
> debugfs exposes device state and list of me clients and their
> properties
>
> Signed-off-by: Tomas Winkler <[email protected]>
Just one small comment:
> +#define DEBUGFS_ADD_FILE(_mei, name, parent, mode) \
> + debugfs_create_file(#name, mode, parent, \
> + _mei, &mei_dbgfs_fops_##name)
This macro seems to obfuscate more than it helps. In general, string
concatenation
in macros is problematic because it means you can no longer grep for where a
symbols is being used.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
