On Fri, Apr 5, 2013 at 6:25 PM, Neil Horman <nhor...@tuxdriver.com> wrote:
> I'm sorry.  Forgot to change the wording of the error for the new model that 
> I'm following here.  Although the message is mostly right as bios is 
> responsible for setting and clearing the IRQ remapping feature bit in the 
> chips capabilities register.
>
> I'll fix and repost Monday

>>> diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c
>>> index d56f8c1..2b56e92 100644
>>> --- a/drivers/iommu/irq_remapping.c
>>> +++ b/drivers/iommu/irq_remapping.c
>>> @@ -19,6 +19,7 @@
>>>  int irq_remapping_enabled;
>>>
>>>  int disable_irq_remap;
>>> +int irq_remap_broken;
>>>  int disable_sourceid_checking;
>>>  int no_x2apic_optout;
>>>
>>> @@ -216,6 +217,17 @@ int irq_remapping_supported(void)
>>>         if (disable_irq_remap)
>>>                 return 0;
>>>
>>> +       if (irq_remap_broken) {
>>> +               WARN_TAINT(1, TAIN_FIRMWARE_WORKAROUND,
>>> +                          "This system BIOS has enabled interrupt 
>>> remapping\n"
>>> +                          "on a chipset that contains an erratum making 
>>> that\n"
>>> +                          "feature unstable.  Please reboot with 
>>> nointremap\n"
>>> +                          "added to the kernel command line and contact\n"
>>> +                          "your BIOS vendor for an update");

Also please put those warning code in to
drivers/iommu/intel_irq_remapping.c::intel_irq_remapping_supported()

It does not belong to drivers/iommu/irq_remapping.c.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to