Hello, On Mon, Apr 08, 2013 at 10:56:40AM +0100, Lin Feng wrote: > In hot add node(memory) case, vmemmap pages are always allocated from other > node, but the current logic just skip vmemmap_verify check. > So we should also issue "potential offnode page_structs" warning messages > if we are the case. > > Cc: Christoph Lameter <[email protected]> > Cc: Catalin Marinas <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Tony Lindgren <[email protected]> > Cc: Ben Hutchings <[email protected]> > Cc: Andrew Morton <[email protected]> > Reported-by: Yasuaki Ishimatsu <[email protected]> > Signed-off-by: Lin Feng <[email protected]> > --- > arch/arm64/mm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 70b8cd4..9f1e417 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -427,8 +427,8 @@ int __meminit vmemmap_populate(struct page *start_page, > return -ENOMEM; > > set_pmd(pmd, __pmd(__pa(p) | prot_sect_kernel)); > - } else > - vmemmap_verify((pte_t *)pmd, node, addr, next); > + } > + vmemmap_verify((pte_t *)pmd, node, addr, next); > } while (addr = next, addr != end); > > return 0;
Given that we don't have NUMA support or memory-hotplug on arm64 yet, I'm not sure that this change makes much sense at the moment. early_pfn_to_nid will always return 0 and we only ever have one node. To be honest, I'm not sure what that vmemmap_verify check is trying to achieve anyway. ia64 does some funky node affinity initialisation early on but, for the rest of us, it looks like we always just check the distance from node 0. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
