Sekhar, On Tue, Apr 9, 2013 at 5:18 PM, Sekhar Nori <nsek...@ti.com> wrote: > On 4/8/2013 2:47 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar <prabhakar.cse...@gmail.com> >> >> Create platform devices for various video modules like venc,osd, >> vpbe and v4l2 driver for dm365. >> >> Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> >> Acked-by: Sekhar Nori <nsek...@ti.com> >> --- > >> diff --git a/arch/arm/mach-davinci/davinci.h >> b/arch/arm/mach-davinci/davinci.h >> index 12d544b..a9de512 100644 >> --- a/arch/arm/mach-davinci/davinci.h >> +++ b/arch/arm/mach-davinci/davinci.h >> @@ -36,8 +36,13 @@ >> #include <media/davinci/vpbe_osd.h> >> >> #define DAVINCI_SYSTEM_MODULE_BASE 0x01c40000 >> +#define SYSMOD_VDAC_CONFIG 0x2c >> #define SYSMOD_VIDCLKCTL 0x38 >> #define SYSMOD_VPSS_CLKCTL 0x44 >> +#define VPSS_VENCCLKEN_ENABLE BIT(3) >> +#define VPSS_DACCLKEN_ENABLE BIT(4) >> +#define VPSS_PLLC2SYSCLK5_ENABLE BIT(5) >> + > > Prabhakar, I noticed it only after I applied these patches, but these > bit definitions in between list of register offsets is distracting. Can > you please move them down after the register offsets when you send the > pull request? You can add a comment /* VPSS CLKCTL bit definitions */ > before you start the bit definitions. > OK, I'll fix it while issuing the pull request.
Regards, --Prabhakar >> #define SYSMOD_VDD3P3VPWDN 0x48 >> #define SYSMOD_VSCLKDIS 0x6c >> #define SYSMOD_PUPDCTL1 0x7c > > Thanks, > Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
