On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote: > On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser > <kevin.stras...@linux.intel.com> wrote: > > > From: Michael Brunner <michael.brun...@kontron.com> > > > > Add gpio support for the on-board PLD found on some Kontron embedded > > modules. > > > > Signed-off-by: Michael Brunner <michael.brun...@kontron.com> > > Signed-off-by: Kevin Strasser <kevin.stras...@linux.intel.com> > > This looks very generic, setting and clearing bits in bytesized > registers. > > Can you please attempt to use generic GPIO for this? > Linus,
I looked into it, but for my part I seem to be missing how the generic GPIO code permits locking access to the hardware (PLD) and setting the PLD's page register. In other words, I don't immediately see how to call kempld_get_mutex_set_index() from the generic GPIO code. The other drivers using generic GPIO code don't seem to have that requirement. Thanks, Guenter > drivers/gpio/gpio-generic.c > <linux/basic_mmio_gpio.h> > > See for example: > gpio-ep93xx.c, gpio-sodaville.c ... > > Since you don't even have IRQ support in this it will be even simpler. > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
