On Fri, Apr 12, 2013 at 3:05 PM, Anthony Olech <[email protected]> wrote:
> This is the GPIO component driver of the Dialog DA9058 PMIC. > This driver is just one component of the whole DA9058 PMIC driver. > It depends on the CORE component driver of the DA9058 MFD. > The meaning of the PMIC register 21 bits 1 and 5 has been documented > in the driver source. > > Signed-off-by: Anthony Olech <[email protected]> > Signed-off-by: David Dajun Chen <[email protected]> Looks OK to me. Acked-by: Linus Walleij <[email protected]> > + /* > + * INP configured pins: > + * 9 == DebounceOn+ActiceLowPullUp > + * > + * OUT configured pins: > + * 7 == PushPull+ExternalPullUpToVDDIO > + * 3 == PushPull+InternalPullUpToVDDIO > + * 2 == OpenDrain+InternalPullUpToVDDIO > + */ > + > + gpio->inp_config = 0x99; > + gpio->out_config = 0x77; Looks pretty hardcoded, and should be - if you want to make this runtime or DT/platforms configurable you need to migrate the driver to pinctrl, which is the place where we do things like this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
