On 2013/4/15 22:15, Jonghwan Choi wrote: > From: libin <[email protected]> > > This patch looks like it should be in the 3.8-stable tree, should we apply > it? >
yes, I think this patch should be applied to the 3.8-stable tree. Thanks. Libin > ------------------ > > From: "libin <[email protected]>" > > commit fd9b86d37a600488dbd80fe60cca46b822bff1cd upstream > > Commit 201c373e8e ("sched/debug: Limit sd->*_idx range on > sysctl") was an incomplete bug fix. > > This patch fixes sd->*_idx limit range to [0 ~ CPU_LOAD_IDX_MAX-1] > avoiding array overflow caused by setting sd->*_idx to CPU_LOAD_IDX_MAX > on sysctl. > > Signed-off-by: Libin <[email protected]> > Cc: <[email protected]> > Cc: <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Link: http://lkml.kernel.org/r/[email protected] > Signed-off-by: Ingo Molnar <[email protected]> > Signed-off-by: Jonghwan Choi <[email protected]> > --- > kernel/sched/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 26058d0..112a32a 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4948,7 +4948,7 @@ static void sd_free_ctl_entry(struct ctl_table **tablep) > } > > static int min_load_idx = 0; > -static int max_load_idx = CPU_LOAD_IDX_MAX; > +static int max_load_idx = CPU_LOAD_IDX_MAX-1; > > static void > set_table_entry(struct ctl_table *entry, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
