On 04/10/2013 02:54 PM, Axel Lin wrote:
The regulator always on with high power mode if info->cfg->hwreq is set.
If we allow set idle mode when info->cfg->hwreq is set, get_mode() returns
REGULATOR_MODE_IDLE but the regulator actually is in REGULATOR_MODE_NORMAL mode.
This patch avoid inconsistent status return by get_mode().
Signed-off-by: Axel Lin <axel....@ingics.com>z
---
drivers/regulator/ab8500-ext.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c
index 9aee21c..f0a1bbf 100644
--- a/drivers/regulator/ab8500-ext.c
+++ b/drivers/regulator/ab8500-ext.c
@@ -192,6 +192,10 @@ static int ab8500_ext_regulator_set_mode(struct
regulator_dev *rdev,
info->update_val = info->update_val_hp;
break;
case REGULATOR_MODE_IDLE:
+ /* Always on with high power mode if info->cfg->hwreq is set */
+ if (info->cfg && info->cfg->hwreq)
+ return -EINVAL;
+
info->update_val = info->update_val_lp;
break;
I prefer to have info->update_val updated to reflect requested mode (in
get_mode) instead of returning -EINVAL. This is how I interpret Mark's
comment on the other patch ([PATCH] regulator: ab8500: Fix get_mode for
shared mode regulators).Otherwise, the patch should work fine.
Regards,
Bengt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
