On Mon, Apr 15, 2013 at 11:47 PM, Colin Cross <ccr...@android.com> wrote: > On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross <ccr...@android.com> wrote: >> Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse >> header with one used in library) added #ifdef __linux__ around >> defines if it is not set. The kernel build is self-contained and >> can be built on non-Linux toolchains. After the mentioned commit >> builds on non-Linux toolchains will try to include stdint.h and >> fail due to -nostdinc, and then fail with a bunch of undefined >> type errors. >> >> Change the #ifdef to check for __linux__ or __KERNEL__ so that >> it uses the kernel typedefs if __KERNEL__ is set. >> >> Signed-off-by: Colin Cross <ccr...@android.com> >> --- >> I think this should go in v3.9, without it bare-metal toolchains >> that don't define __linux__ will fail to compile the kernel, and >> cross-compiles from non-linux hosts will probably also fail. > > Miklos, I see Arve sent an equivalent patch to you a month ago > (https://lkml.org/lkml/2013/3/11/620), and I agree with his response > to your question (checking for __linux__ and __KERNEL__ is better than > just checking for __KERNEL__ if you want this header to be used in > userspace builds on linux targets).
And I still disagree. Why should userspace use the linux internal header when there's a perfectly good standard header that it can use? Patch committed and pushed to for-next and for-linus. I'll push to Linus tomorrow. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/