On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote: > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote: > > } > > list_add(&dev->list, &blkmtd_device_list); > > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index, > > - dev->mtd.name + strlen("block2mtd: "), > > - dev->mtd.erasesize >> 10, dev->mtd.erasesize); > > + pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n", > > + dev->mtd.index, > > + dev->mtd.name + strlen("block2mtd: "), > > + dev->mtd.erasesize >> 10, dev->mtd.erasesize); > > I personally dislike the indent-to-braces style because it causes > unnecessary churn in patches like this.
It comes from an automated emacs conversion. > The reindenting improves nothing at all. Debatable. > It will waste time when people care about revision history because > they encounter a bug, want a fix quick and are pressed for time. Not really if you use existing tools with options. Try: git diff -w git blame -w > If you care about my ack, please remove random churn. This is not a > competition about who gets the most lines in git blame. I care not at all about commit counts, nor things like lines added or removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/