From: Asias He <[email protected]> Date: Wed, 24 Apr 2013 14:33:52 +0800
> When we call vsock_core_init to init VSOCK the second time, > vsock_device.minor still points to the old dynamically allocated minor > number. misc_register will allocate it for us successfully as if we were > asking for a static one. However, when other user call misc_register to > allocate a dynamic minor number, it will give the one used by > vsock_core_init(), causing this: > > [ 405.470687] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0xcc/0xf0() > [ 405.470689] Hardware name: OptiPlex 790 > [ 405.470690] sysfs: cannot create duplicate filename '/dev/char/10:54' > > Always set vsock_device.minor to MISC_DYNAMIC_MINOR before we > register. > > Cc: "David S. Miller" <[email protected]> > Cc: Andy King <[email protected]> > Cc: Dmitry Torokhov <[email protected]> > Cc: Reilly Grant <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Asias He <[email protected]> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
