On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones <[email protected]> wrote: > > > The current implementation of the DMA40's local MAX() macro evaluates > > its arguments more times than is necessary. This patch strips it > > optimises it to only evaluate what's appropriate. > > > > Cc: Vinod Koul <[email protected]> > > Cc: Dan Williams <[email protected]> > > Cc: Per Forlin <[email protected]> > > Cc: Rabin Vincent <[email protected]> > > Reported-by: Harvey Harrison <[email protected]> > > Signed-off-by: Lee Jones <[email protected]> > (...) > > -#define MAX(a, b) (((a) < (b)) ? (b) : (a)) > > +#define MAX(a, b) ((a > b) ? a : b) > > Much has been said about this patch already, but notice what it is > used for instead, one single thing at compile-time: > > struct d40_base { > (...) > u32 > reg_val_backup_v4[MAX(BACKUP_REGS_SZ_V4A, BACKUP_REGS_SZ_V4B)]; > (...) > }; > > i.e. defining the size of that array at compile-time. > > The actual size is figured out in d40_hw_detect_init(). > > So what about you just devm_kmalloc() that array instead and > delete this macro. That is the real fix.
I'm happy to do it, but please see v2 of this patch first. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
