On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones <lee.jo...@linaro.org> wrote:
> The DMA controller currently takes configuration information from
> information passed though dma_channel_request(), but it shouldn't.
> Using the API, the DMA channel should only be configured during
> a dma_slave_config() call.
>
> Cc: Herbert Xu <herb...@gondor.apana.org.au>
> Cc: David S. Miller <da...@davemloft.net>
> Cc: Andreas Westin <andreas.wes...@stericsson.com>
> Cc: linux-cry...@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jo...@linaro.org>
(...)
> /* Cryp DMA interface */
> +#define HASH_DMA_TX_FIFO 0x08
> +#define HASH_DMA_RX_FIFO 0x10
Yes, this is nice address notation :-)
> /**
> * struct cryp_device_data - structure for a cryp device.
> - * @base: Pointer to the hardware base address.
> + * @base: Pointer to virtual base address of the cryp device.
> + * @phybase: Pointer to physical memory location of the cryp device.
> * @dev: Pointer to the devices dev structure.
> * @clk: Pointer to the device's clock control.
> * @pwr_regulator: Pointer to the device's power control.
> @@ -232,6 +236,7 @@ struct cryp_dma {
> */
> struct cryp_device_data {
> struct cryp_register __iomem *base;
> + phys_addr_t phybase;
Use dma_addr_t. Maybe "phybase" is misleading,
"dmabase" is probably better. (Also applies to the
cryp patch).
Apart from that it looks allright.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
