On Wed, Apr 24, 2013 at 12:58 PM, Lee Jones <[email protected]> wrote:
> Currently, if DMA information isn't passed from platform data, then DMA > will not be used. This patch allows DMA information obtained though Device > Tree to be used as well. > > Cc: Russell King <[email protected]> > Cc: Chris Ball <[email protected]> > Cc: [email protected] > Signed-off-by: Lee Jones <[email protected]> (...) I tried to test this patch, but: CC drivers/mmc/host/mmci.o /drivers/mmc/host/mmci.c: In function 'mmci_dma_setup': /drivers/mmc/host/mmci.c:307:51: error: 'dev' undeclared (first use in this function) /drivers/mmc/host/mmci.c:307:51: note: each undeclared identifier is reported only once for each function it appears in make[5]: *** [drivers/mmc/host/mmci.o] Error 1 make[4]: *** [drivers/mmc/host] Error 2 make[3]: *** [drivers/mmc] Error 2 Due to: > @@ -304,10 +304,8 @@ static void mmci_dma_setup(struct mmci_host *host) > const char *rxname, *txname; > dma_cap_mask_t mask; > > - if (!plat || !plat->dma_filter) { > - dev_info(mmc_dev(host->mmc), "no DMA platform data\n"); > - return; > - } > + host->dma_rx_channel = dma_request_slave_channel(dev, "rx"); > + host->dma_tx_channel = dma_request_slave_channel(dev, "tx"); There is no "dev" here. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

