On 04/30/2013 04:02 PM, Stefano Stabellini wrote: > On Mon, 29 Apr 2013, Julien Grall wrote: >> Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by >> default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call >> irq_startup, that is responsible for calling irq_unmask at startup time. >> As a result event channels remain masked. >> >> The clear is already made in bind_evtchn_to_irq with commit a8636c0 but was >> missing in bind_virq_to_irq. >> >> Signed-off-by: Julien Grall <julien.gr...@linaro.org> > > As in the original commit, you should point out that this change does > not have any effects on x86 (where IRQ_NOREQUEST and IRQ_NOAUTOEN are > cleared by default). > > At this point we might as well do this consistently everywhere we > allocate a new evtchn irq, including pirqs and ipis, even though we don't > actually use them on ARM. > > If the call to irq_clear_status_flags can be moved earlier, a good place > for it could be xen_irq_init.
Thanks for the review. I will give a try and send a version with it if the solution works. -- Julien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/