On 02/05/2013 10:12, Richard Genoud :
2013/5/2 Yang, Wenyou <[email protected]>:
Hi, Joachim,
-----Original Message-----
From: Joachim Eastwood [mailto:[email protected]]
Sent: 2013年3月7日 20:31
To: Yang, Wenyou
Cc: [email protected]; [email protected]; Ferre,
Nicolas; [email protected]; [email protected]; Lin, JM;
[email protected]; [email protected]
Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after
xfer->speed_hz set
On 7 March 2013 04:26, Wenyou Yang <[email protected]> wrote:
commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e
cause the atmel spi probing failure.
Signed-off-by: Wenyou Yang <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/spi/spi-atmel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 656d137..1eca815 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi,
struct spi_message *msg)
}
}
- /* FIXME implement these protocol options!! */
- if (xfer->speed_hz) {
- dev_dbg(&spi->dev, "no protocol options
yet\n");
+ if (xfer->speed_hz < spi->max_speed_hz) {
+ dev_dbg(&spi->dev,
+ "speed in transfer less than bus
speed\n");
return -ENOPROTOOPT;
}
I sent a similar patch to spi-devl a while ago, which Grant said he applied.
https://patchwork.kernel.org/patch/2165301/
Can't find the patch in any upstream git tree so I guess Grant hasn't
pushed it yet.
This patch hasn't still applied in any upstream git tree, so Atmel spi master
doesn't work.
Could you help do some ping it?
it's in linux-next:
3d3522604a5557e80fdcab61c54bd04eaf15b525
merged from spi-current/spi/merge
Thanks Richard, yes I can find it here:
http://git.secretlab.ca/?p=linux.git;a=commit;h=3d3522604a5557e80fdcab61c54bd04eaf15b525
Grant, Mark,
Can you tell us if this SPI patch will be merged upstream using one of
your paths?
Best regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
