On Thu, May 02, 2013 at 04:07:53PM +0200, Jens Axboe wrote: > On Thu, May 02 2013, Philip J. Kelleher wrote: > > On Thu, May 02, 2013 at 10:03:25AM +0200, Jens Axboe wrote: > > > On Wed, May 01 2013, Philip J. Kelleher wrote: > > > > #define NO_LEGACY 0 > > > > +#define DEBUGFS_NULL NULL > > > > > > > > +static struct dentry *rsxx_debugfs_root = DEBUGFS_NULL; > > > > > > What's the point of DEBUGFS_NULL? > > > > Well, orginally, I had rsxx_debugfs_root initialized to NULL but > > the checkpatch script told me not to initialize directly with 0 > > or NULL. So my solution is the #define macro. > > Well, it's a static variable. The reason checkpatch tells you not to > initialize it to NULL/0 is because the bss is automatically zeroed. >
Alright sounds good, I'll remove it. Has the patch series been applied and a new patch with the proper change need to sent or does the entire patch series need to be resubmitted? > -- > Jens Axboe > Thanks, -Philip Kelleher -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
