Hi Dirk, On Thu, May 02, 2013 at 09:11:19PM +0200, Dirk Eibach wrote: > Hi Guenter, > > >>diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > >>index e89fc31..6048593 100644 > >>--- a/drivers/watchdog/Kconfig > >>+++ b/drivers/watchdog/Kconfig > >>@@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT > >> > >> The value can be overridden by the wdt_period command-line > >>parameter. > >> > >>+choice > >>+ prompt "PowerPC Book-E Watchdog reset type" > >>+ depends on BOOKE_WDT > >>+ default BOOKE_WDT_RESET_CHIP > >>+ help > >>+ Specify what kind of reset will be executed on watchdog timeout. > >>+ > >Seems to me it would be much better to make this configurable via > >platform data > >and/or device tree. > > good catch. What do the device-tree gurus think to be a nice > property name? > How about "reset-type" ? If that is not acceptable, a more device specific name might be "booke-reset-type".
I would suggest to write a patch including property description and copy devicetree-discuss when you submit it. If devicetree works for your application, I would not bother with platform data. Btw, do you have an opinion about the timeout ? I'd like to get rid of the configuration parameter, as it is quite confusing (try to match the parameter to seconds on a Freescale processor and you'll understand what I mean). I asked about it on the list a while ago, but did not get any feedback. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
