On Wed, 08 May 2013, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:21AM +0200, Fabio Baltieri wrote: > > Set AD_OUT1 and AD_OUT2, corresponding to LINL and LINR pins, as the > > default input slots for the capture interfaces. > > If these are routing specific analogue inputs to specific timeslots then > this is routing that should be being exposed to DAPM as muxes, not hard > coded in the middle of TDM slot configuration (which is both obscure and > not what the TDM API is there for). The TDM API should be purely about > placing the timeslots for the audio interface on the bus.
Again, I think this patch is a valid bugfix. If the driver requires refactoring, it should be done by someone else. That's not the purpose of Fabio's role. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
