On Wednesday, May 08, 2013 09:09:29 AM GBGamer wrote:
> Fixed coding style problems in battery.c
First off, patches without a sign-off are not applicable.
Second, ->
> ---
> drivers/acpi/battery.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index e710045..3c1784b 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -663,9 +663,9 @@ static void acpi_battery_quirks(struct acpi_battery
> *battery)
> if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags))
> return ;
>
> - if (battery->full_charge_capacity == 100 &&
> - battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN &&
> - battery->capacity_now >=0 && battery->capacity_now <= 100) {
> + if (battery->full_charge_capacity == 100 &&
> + battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN &&
> + battery->capacity_now >=0 && battery->capacity_now <= 100) {
-> this isn't entirely correct, because the indentation pattern used in the
kernel for continuations of if () conditionals is one tab and four spaces
(whereas you've used two tabs).
> set_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY,
> &battery->flags);
> battery->full_charge_capacity = battery->design_capacity;
> battery->capacity_now = (battery->capacity_now *
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
