On Fri, May 10, 2013 at 1:47 PM, Wolfram Sang <w...@the-dreams.de> wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <w...@the-dreams.de> > --- > drivers/pinctrl/spear/pinctrl-plgpio.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c > b/drivers/pinctrl/spear/pinctrl-plgpio.c > index 3e5a887..6b090be 100644 > --- a/drivers/pinctrl/spear/pinctrl-plgpio.c > +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c > @@ -528,18 +528,13 @@ static int plgpio_probe(struct platform_device *pdev) > struct resource *res; > int ret, irq, i; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "invalid IORESOURCE_MEM\n"); > - return -EBUSY; > - } > - > plgpio = devm_kzalloc(&pdev->dev, sizeof(*plgpio), GFP_KERNEL); > if (!plgpio) { > dev_err(&pdev->dev, "memory allocation fail\n"); > return -ENOMEM; > } > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > plgpio->base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(plgpio->base)) > return PTR_ERR(plgpio->base);
Acked-by: Viresh Kumar <viresh.ku...@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/