On Mon, May 6, 2013 at 9:30 AM, Chao Xie <[email protected]> wrote: > Old pwm-pxa.c will register driver by arch_initcall. Then other > drivers based on the PWM driver can successully call old > pwm_request because arch_initcall make sure the PWM driver will > be registered earlier. > Now, pwm_request is re-written and done by common layer code. It > will return -EPROBE_DEFER if the PWM device is not probed. > The driver based on PWM driver can make use of -EPROBE_DEFER > to delay its probing. > So arch_initcall can be replaced by module_platform_driver. > > Signed-off-by: Chao Xie <[email protected]>
Looks good to me, Acked-by: Eric Miao <[email protected]> > --- > drivers/pwm/pwm-pxa.c | 12 +----------- > 1 files changed, 1 insertions(+), 11 deletions(-) > > diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c > index dee6ab55..aa4bea7 100644 > --- a/drivers/pwm/pwm-pxa.c > +++ b/drivers/pwm/pwm-pxa.c > @@ -187,16 +187,6 @@ static struct platform_driver pwm_driver = { > .id_table = pwm_id_table, > }; > > -static int __init pwm_init(void) > -{ > - return platform_driver_register(&pwm_driver); > -} > -arch_initcall(pwm_init); > - > -static void __exit pwm_exit(void) > -{ > - platform_driver_unregister(&pwm_driver); > -} > -module_exit(pwm_exit); > +module_platform_driver(pwm_driver); > > MODULE_LICENSE("GPL v2"); > -- > 1.7.4.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
