On Fri, May 10, 2013 at 11:17:29PM +0800, Alex Shi wrote: > blocked_load_avg sometime is too heavy and far bigger than runnable load > avg. that make balance make wrong decision. So better don't consider it.
Would you happen to have an example around that illustrates this? Also, you've just changed the cgroup balancing -- did you run any tests on that? > Signed-off-by: Alex Shi <[email protected]> > --- > kernel/sched/fair.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 91e60ac..75c200c 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1339,7 +1339,7 @@ static inline void > __update_cfs_rq_tg_load_contrib(struct cfs_rq *cfs_rq, > struct task_group *tg = cfs_rq->tg; > s64 tg_contrib; > > - tg_contrib = cfs_rq->runnable_load_avg + cfs_rq->blocked_load_avg; > + tg_contrib = cfs_rq->runnable_load_avg; > tg_contrib -= cfs_rq->tg_load_contrib; > > if (force_update || abs64(tg_contrib) > cfs_rq->tg_load_contrib / 8) { > -- > 1.7.5.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
