On Wed, May 15, 2013 at 10:51:58AM +0100, Lee Jones wrote: > Unsure of the author's intentions, rather than just removing the nop, > we're replacing it with a comment containing the possible intention > of the statement OR:ing with 0. Would be worthwhile to check w/ Linus W on this (or check whom to blame)
-- ~Vinod > > Cc: Vinod Koul <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Per Forlin <[email protected]> > Cc: Rabin Vincent <[email protected]> > Signed-off-by: Lee Jones <[email protected]> > --- > drivers/dma/ste_dma40_ll.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/ste_dma40_ll.c b/drivers/dma/ste_dma40_ll.c > index a035dfe..27b818d 100644 > --- a/drivers/dma/ste_dma40_ll.c > +++ b/drivers/dma/ste_dma40_ll.c > @@ -182,8 +182,10 @@ static int d40_phy_fill_lli(struct d40_phy_lli *lli, > else > lli->reg_cfg &= ~BIT(D40_SREG_CFG_TIM_POS); > > - /* Post link */ > - lli->reg_lnk |= 0 << D40_SREG_LNK_PHY_PRE_POS; > + /* > + * Post link - D40_SREG_LNK_PHY_PRE_POS = 0 > + * Relink happens after transfer completion. > + */ > > return 0; > } > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
