Daniel writes [re index directories]: > This is lightly tested and apparently stable. I was looking at the new patch, and I saw something that puzzles me. Why do you set the EXT2_INDEX_FL on a new (empty) directory, rather than only setting it when the dx_root index is created? Setting the flag earlier than that makes it mostly useless, since it will be set on basically every directory. Not setting it would also make your is_dx() check simply a check for the EXT2_INDEX_FL bit (no need to also check size). Also no need to set EXT2_COMPAT_DIR_INDEX until such a time that we have a (real) directory with an index, to avoid gratuitous incompatibility with e2fsck. Cheers, Andreas -- Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto, \ would they cancel out, leaving him still hungry?" http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Re: [PATCH][CFT] (updated) ext2 directories in pagecache Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Albert Cranford
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pa... Albert Cranford
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pa... Andreas Dilger
- Re: [PATCH][CFT] (updated) ext2 directories i... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Andreas Dilger
- Re: [PATCH][CFT] (updated) ext2 directories in pa... Daniel Phillips
- CMD64x - full DMA support? Paul Dorman
- Re: [PATCH][CFT] (updated) ext2 directories i... Andreas Dilger
- Re: [PATCH][CFT] (updated) ext2 directori... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directori... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Andreas Dilger
- Re: [PATCH][CFT] (updated) ext2 directories in pa... Daniel Phillips
- Re: [PATCH][CFT] (updated) ext2 directories in pageca... Andreas Dilger