On Friday 17 May 2013 15:35:43 Oliver Schinagl wrote: > +static struct bin_attribute sid_bin_attr = { > + .attr = { > + .name = "key", > + .mode = S_IRUGO, > + }, > + .size = SUNXI_SID_SIZE, > + .read = sid_read, > +};
I believe all the other drivers in drivers/misc/eeprom use "eeprom" as the name for the attribute, so using "key" here is a bit inconsistent. Can you change that? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/